fix: return return_to code if already authenticated
#4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
approved these changes
Feb 2, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4286 +/- ##
==========================================
+ Coverage 78.59% 78.62% +0.02%
==========================================
Files 381 381
Lines 27382 27384 +2
==========================================
+ Hits 21521 21530 +9
+ Misses 4238 4232 -6
+ Partials 1623 1622 -1 ☔ View full report in Codecov by Sentry. |
hperl
force-pushed
the
hperl/fix-always-issue-return_to_code-for-native-oidc
branch
from
aa4fce4 to
1dbe670
Compare
zepatrik
approved these changes
Feb 3, 2025
zepatrik
deleted the
hperl/fix-always-issue-return_to_code-for-native-oidc
branch
mpauly-exnaton
pushed a commit
to mpauly-exnaton/kratos
that referenced
this pull request
Feb 12, 2025
This fixes a bug in native OIDC login and registration flows, where the user already has a session in the browser the flow is continued with (usually a web view, but depending on the platform it already has a session cookie set). In the callback, we now correctly handle the case in `alreadyAuthenticated` to return the session token exchange code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in native OIDC login and registration flows, where the user already has a session in the browser the flow is continued with (usually a web view, but depending on the platform it already has a session cookie set). In the callback, we now correctly handle the case in
alreadyAuthenticatedto return the session token exchange code.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments